-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
Add 'Show translation source' to docs sidebar #130355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
I suggest to change the PR title to make it clear it's about the docs. |
|
I'm -1 on this. A |
|
I often use "show source" when I want to check, well, the source, for example if there's something amiss. If there's a translation that's missing or fixing, is the .po file the file that needs editing? If so, this would make it easy to click through and make a quick PR. |
|
Hugo already mentioned the main point. Another thing is the current „show source” button is useless in the translations as it is the English source. This will contributions as it is easy to find where the files are as the repo is not linked anywhere else in the docs! And also, Adam, you don’t have to worry about seeing it :-) |
|
I personally use "Show source" very rarely. But I think "Show translation source" would be as useful as "Show source" is, for translated content. |
|
Is there anything else left to do here @hugovk ? |
|
Friendly ping, so that we can get this in. |
|
Adam is -1, let me check in with him. We're not in a rush to get this in before the beta feature freeze, it can also go in after and be backported. |
That question wasn’t answered directly (assuming it wasn’t just rhetorical). Yes, the .po file should be edited in case of a missing or incorrect translation. That’s a good point—using PR-based translation workflows, this should be a convenient change. |
|
We could use Plausible custom events to track the usage of the show source link. Though it looks like it would require changes in both theme and the show source customization in the CPython's repo. |
|
Friendly ping, it would be nice to get this going again @hugovk / @AA-Turner :-) |
|
@StanFromIreland What would the "Show Translation Source" display? |
It would show that text, but in the language of the translation you're looking at. And with a link to the |
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
Let's try this. |
|
Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
(cherry picked from commit 6cddf04) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Maciej Olko <maciej.olko@affirm.com>
(cherry picked from commit 6cddf04) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Maciej Olko <maciej.olko@affirm.com>
|
GH-142686 is a backport of this pull request to the 3.14 branch. |
|
GH-142687 is a backport of this pull request to the 3.13 branch. |
Discussion sphinx-doc/sphinx#13301
📚 Documentation preview 📚: https://cpython-previews--130355.org.readthedocs.build/