Skip to content

Conversation

@arthurlw
Copy link
Contributor

@arthurlw arthurlw commented Feb 25, 2025

@ghost
Copy link

ghost commented Feb 25, 2025

All commit authors signed the Contributor License Agreement.
CLA signed

@picnixz
Copy link
Member

picnixz commented Feb 25, 2025

I don't think we need to explain in the seealso block what each function does. I think it's fine to have an inline "See also the functions X, Y and Z" to avoid repeating links (similar to what we currently do for os.path.split).

Note: I'm leaving until Saturday, so I won't have time to review the changes until then.

@picnixz picnixz self-requested a review March 19, 2025 01:01
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

friendly ping @barneygale


If a segment is an absolute path (which on Windows requires both a drive and
a root), then all previous segments are ignored and joining continues from the
absolute path segment. For example::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, this example is non-Windows only right? namely macOS and Linux right? If so, I would add "On Linux, for example::" (the paragraph is not exactly Linux specific but the example is)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, good catch! I committed the fix

@hugovk hugovk removed the needs backport to 3.12 only security fixes label Apr 10, 2025
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@hugovk hugovk changed the title gh-130536: Added details to os.path documentation gh-130536: Add details to os.path documentation Dec 16, 2025
@hugovk hugovk merged commit ba587ed into python:main Dec 16, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Dec 16, 2025
@miss-islington-app
Copy link

Thanks @arthurlw for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2025
)

(cherry picked from commit ba587ed)

Co-authored-by: Arthur Wigo <arthur.l.wigo@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2025
)

(cherry picked from commit ba587ed)

Co-authored-by: Arthur Wigo <arthur.l.wigo@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 16, 2025

GH-142800 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 16, 2025
@bedevere-app
Copy link

bedevere-app bot commented Dec 16, 2025

GH-142801 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 16, 2025
hugovk pushed a commit that referenced this pull request Dec 16, 2025
…142800)

Co-authored-by: Arthur Wigo <arthur.l.wigo@gmail.com>
hugovk pushed a commit that referenced this pull request Dec 16, 2025
…142801)

Co-authored-by: Arthur Wigo <arthur.l.wigo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants