bpo-34682: Wording and grammatical changes to the doc(https://docs.python.org/3) #13120
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
ericvsmith
left a comment
ericvsmith
left a comment
There was a problem hiding this comment.
Other than my comments, this looks good. Thanks!
| .. method:: generator.__next__() | ||
|
|
||
| Starts the execution of a generator function or resumes it at the last | ||
| executed yield expression. When a generator function is resumed with a |
There was a problem hiding this comment.
I think the original "a" is correct here, although I realize there's some wiggle room.
Doc/reference/expressions.rst
Outdated
| The operators :keyword:`is` and :keyword:`is not` test for object identity: ``x | ||
| is y`` is true if and only if *x* and *y* are the same object. Object identity | ||
| The operators :keyword:`is` and :keyword:`is not` test for object's identity: ``x | ||
| is y`` is true if and only if *x* and *y* are the same object. Object's identity |
There was a problem hiding this comment.
And same here: "An object's identity ..."
Doc/reference/expressions.rst
Outdated
|
|
||
| The operators :keyword:`is` and :keyword:`is not` test for object identity: ``x | ||
| is y`` is true if and only if *x* and *y* are the same object. Object identity | ||
| The operators :keyword:`is` and :keyword:`is not` test for object's identity: ``x |
There was a problem hiding this comment.
I would make this "test for an object's identity" (adding "an").
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @ericvsmith: please review the changes made to this pull request. |
|
Thanks @divyag9 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
…thon.org/3) (pythonGH-13120) https://bugs.python.org/issue34682 (cherry picked from commit 778a910) Co-authored-by: divyag9 <divyam9@gmail.com>
|
GH-13279 is a backport of this pull request to the 3.7 branch. |
|
@divyag9 Congratulations on getting your PR merged! 🎉 🎉 |
…ocs.python.org/3) (pythonGH-13120) https://bugs.python.org/issue34682 (cherry picked from commit 778a910) Co-authored-by: divyag9 <divyam9@gmail.com>
…ocs.python.org/3) (GH-13120) (GH-13281) https://bugs.python.org/issue34682 (cherry picked from commit 778a910) Co-authored-by: divyag9 <divyam9@gmail.com>
7 participants
https://bugs.python.org/issue34682