Skip to content

gh-131234: Improve test_popen with more asserts#131235

Merged
sobolevn merged 2 commits intopython:mainfrom
sobolevn:issue-131234
Mar 14, 2025
Merged

gh-131234: Improve test_popen with more asserts#131235
sobolevn merged 2 commits intopython:mainfrom
sobolevn:issue-131234

Conversation

@sobolevn
Copy link
Copy Markdown
Member

@sobolevn sobolevn commented Mar 14, 2025

@sobolevn sobolevn added tests Tests in the Lib/test dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 14, 2025
@sobolevn sobolevn requested a review from picnixz March 14, 2025 11:10
Comment thread Lib/test/test_popen.py
Comment thread Lib/test/test_popen.py
@sobolevn
Copy link
Copy Markdown
Member Author

Done!

@sobolevn sobolevn enabled auto-merge (squash) March 14, 2025 11:16
@sobolevn sobolevn merged commit fc07f86 into python:main Mar 14, 2025
42 checks passed
@miss-islington-app
Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 14, 2025
)

(cherry picked from commit fc07f86)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 14, 2025

GH-131240 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 14, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 14, 2025
)

(cherry picked from commit fc07f86)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 14, 2025

GH-131241 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 14, 2025
sobolevn added a commit that referenced this pull request Mar 14, 2025
…131241)

gh-131234: Improve `test_popen` with more asserts (GH-131235)
(cherry picked from commit fc07f86)

Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Mar 14, 2025
…131240)

gh-131234: Improve `test_popen` with more asserts (GH-131235)
(cherry picked from commit fc07f86)

Co-authored-by: sobolevn <mail@sobolevn.me>
mikec9 pushed a commit to mikec9/cpython that referenced this pull request Mar 14, 2025
…nGH-131235) (python#131241)

pythongh-131234: Improve `test_popen` with more asserts (pythonGH-131235)
(cherry picked from commit fc07f86)

Co-authored-by: sobolevn <mail@sobolevn.me>
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants