gh-122040: Reword Modules/xxmodule.c module-level comment#132201
Merged
picnixz merged 2 commits intopython:mainfrom Apr 7, 2025
Merged
gh-122040: Reword Modules/xxmodule.c module-level comment#132201picnixz merged 2 commits intopython:mainfrom
Modules/xxmodule.c module-level comment#132201picnixz merged 2 commits intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
picnixz
reviewed
Apr 7, 2025
picnixz
added
skip news
needs backport to 3.12
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
approved these changes
Apr 7, 2025
Member
|
Thank you for the fix! |
picnixz
changed the title
Modules/xxmodule.c module-level comment
|
Thanks @sonnyding1 for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 7, 2025
…thonGH-132201) (cherry picked from commit af8d1b9) Co-authored-by: Sonny Ding <93831983+sonnyding1@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 7, 2025
…thonGH-132201) (cherry picked from commit af8d1b9) Co-authored-by: Sonny Ding <93831983+sonnyding1@users.noreply.github.com>
|
GH-132207 is a backport of this pull request to the 3.13 branch. |
|
GH-132208 is a backport of this pull request to the 3.12 branch. |
picnixz
pushed a commit
that referenced
this pull request
Apr 7, 2025
picnixz
pushed a commit
that referenced
this pull request
Apr 7, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122040. As per the discussion in the issue, I have modified some comments that might cause confusion.
Modules/xxmodule.c#122040