[3.7] bpo-24538: Fix bug in shutil involving the copying of xattrs to read-only files. (PR-13212)#13234
Merged
giampaolo merged 1 commit intopython:3.7from May 14, 2019
Merged
Conversation
…only files. (PR-13212) Extended attributes can only be set on user-writeable files, but shutil previously first chmod()ed the destination file to the source's permissions and then tried to copy xattrs. This will cause failures if attempting to copy read-only files with xattrs, as occurs with Git clones on Lustre FS. (cherry picked from commit 79efbb7) Co-authored-by: Olexa Bilaniuk <obilaniu@users.noreply.github.com>
Contributor
Author
|
@obilaniu and @giampaolo: Status check is done, and it's a failure ❌ . |
1 similar comment
Contributor
Author
|
@obilaniu and @giampaolo: Status check is done, and it's a failure ❌ . |
Contributor
|
Looks like a flaky test |
|
@giampaolo: Please replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended attributes can only be set on user-writeable files, but shutil previously
first chmod()ed the destination file to the source's permissions and then tried to
copy xattrs. This will cause failures if attempting to copy read-only files with
xattrs, as occurs with Git clones on Lustre FS.
(cherry picked from commit 79efbb7)
Co-authored-by: Olexa Bilaniuk obilaniu@users.noreply.github.com
https://bugs.python.org/issue24538