gh-132390: Apply Ruff linting to Tools/build#132391
Conversation
Tools/build with existing ruff configuration
|
@AA-Turner @hugovk Does it look acceptable or would you prefer to just exclude the files instead of ruffing them? |
This reverts commit af4a0ea.
|
I'll actually hold the merge a bit more so that code owners can also give their opinion. |
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks like a nice cleanup to me, but I'm not the person maintaining most of these scripts :-)
make sure to get signoff from the relevant maintainers before landing this. Not everybody on the team is necessarily on board with stricter linting in CI!
Yes, that's why I eventually decided to hold off the merge! |
|
Ok so here is how I decided to make the change:
|
sethmlarson
left a comment
There was a problem hiding this comment.
LGTM for generate_sbom.py.
| extra_defs, | ||
| 'Some extra declarations were found in "Include/Python.h" ' | ||
| + 'with Py_LIMITED_API:') | ||
| 'with Py_LIMITED_API:') |
There was a problem hiding this comment.
Here, I did want to point out that it's a single string and not a forgotten comma.
Could you point me to the reasoning behind this change?
Tools/buildusing existing ruff configuration #132390