Skip to content

bpo-37046: PEP 586: Add Literal to typing module#13572

Merged
ilevkivskyi merged 4 commits intopython:masterfrom
ilevkivskyi:add-literal
May 26, 2019
Merged

bpo-37046: PEP 586: Add Literal to typing module#13572
ilevkivskyi merged 4 commits intopython:masterfrom
ilevkivskyi:add-literal

Conversation

@ilevkivskyi
Copy link
Copy Markdown
Member

@ilevkivskyi ilevkivskyi commented May 25, 2019

cc @Michael0x2a @JukkaL

The implementation is straightforward and essentially is just copied from typing_extensions.

https://bugs.python.org/issue37046

Comment thread Doc/library/typing.rst Outdated
Comment thread Doc/library/typing.rst Outdated
Comment thread Lib/test/test_typing.py
Comment thread Lib/test/test_typing.py Outdated
Comment thread Lib/test/test_typing.py Outdated
Copy link
Copy Markdown
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM now!

@ilevkivskyi ilevkivskyi merged commit b891c46 into python:master May 26, 2019
@bedevere-bot
Copy link
Copy Markdown

@ilevkivskyi: Please replace # with GH- in the commit message next time. Thanks!

@ilevkivskyi ilevkivskyi deleted the add-literal branch May 26, 2019 08:37
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
The implementation is straightforward and essentially is just copied from `typing_extensions`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants