gh-141218: Fix inaccurate object comparison documentation #141221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed "Objects of different types, except different numeric types, never compare equal" to "Objects of different types, unless documented otherwise, never compare equal" to account for documented exceptions like set/frozenset comparisons.
|
All commit authors signed the Contributor License Agreement. |
OTheDev
reviewed
Nov 8, 2025
Misc/NEWS.d/next/Documentation/2025-11-08-12-00-00.gh-issue-141218.kL3mNx.rst
Outdated
Show resolved
Hide resolved
Contributor
|
I suggest just revert news. Its usually not required for docs changes. |
skirpichev
added
needs backport to 3.13
skirpichev
approved these changes
Nov 10, 2025
OTheDev
approved these changes
Nov 10, 2025
picnixz
reviewed
Nov 15, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
approved these changes
Nov 15, 2025
|
Thanks @mohsinm-dev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 16, 2025
…onGH-141221) (cherry picked from commit b372bd7) Co-authored-by: Mohsin Mehmood <55545648+mohsinm-dev@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 16, 2025
…onGH-141221) (cherry picked from commit b372bd7) Co-authored-by: Mohsin Mehmood <55545648+mohsinm-dev@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-142810 is a backport of this pull request to the 3.14 branch. |
|
GH-142811 is a backport of this pull request to the 3.13 branch. |
hugovk
pushed a commit
that referenced
this pull request
Dec 16, 2025
hugovk
pushed a commit
that referenced
this pull request
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #141218 by correcting inaccurate documentation about object comparison.
Problem: The current documentation states "Objects of different types, except different numeric types, never compare equal" which is factually incorrect.
Counter-example:
Solution: Changed to "Objects of different types, unless documented otherwise, never compare equal" to account for all documented exceptions.
Documented exceptions include:
Changes
Doc/library/stdtypes.rstline 167Misc/NEWS.d/next/Documentation/Test plan
make htmlThe fix improves documentation accuracy while maintaining clarity and consistency.
📚 Documentation preview 📚: https://cpython-previews--141221.org.readthedocs.build/