gh-141692: Add a slice-specific lib folder to iOS XCframeworks. #141693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
requested review from
AA-Turner,
emmatyping and
erlend-aasland
as code owners
ned-deily
approved these changes
Nov 18, 2025
Member
ned-deily
left a comment
ned-deily
left a comment
There was a problem hiding this comment.
Looks to me like a good idea.
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 19, 2025
…pythonGH-141693) Modifies the iOS XCframework to include a lib folder for each slice that contains a symlinked version of the libPython dynamic library. (cherry picked from commit 7b0b708) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
|
GH-141733 is a backport of this pull request to the 3.14 branch. |
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…python#141693) Modifies the iOS XCframework to include a lib folder for each slice that contains a symlinked version of the libPython dynamic library.
ashm-dev
pushed a commit
to ashm-dev/cpython
that referenced
this pull request
Dec 8, 2025
…python#141693) Modifies the iOS XCframework to include a lib folder for each slice that contains a symlinked version of the libPython dynamic library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
libfolder to each slice of an iOS XCframework that contains alibpython*.dylibsymlink to the underlying Framework dylib.This mirrors the structure of macOS frameworks, allowing iOS binary modules to be compiled with
-L path/to/python/lib -lpython, rather than requiring-F path/to/Framework -framework Python. This increases compatibility with standard Unix tooling for building binary modules.The
libpython*.dylibmust be explicitly excluded from being copied into the architecture-specific library folders, so that the dylib (or a symlink) won't be copied into the app binary.The final structure of a full XCframework will look something like: