Skip to content

Fix typo: is_skipped_line to is_skipped_module #141771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gaogaotiantian merged 1 commit into from
Nov 20, 2025
Merged

Fix typo: is_skipped_line to is_skipped_module #141771

gaogaotiantian merged 1 commit into from
Nov 20, 2025

Conversation

@guoci
Copy link
Contributor

@guoci guoci commented Nov 19, 2025 •
edited by github-actions bot
Loading

skip issue, skip news
src:

cpython/Lib/bdb.py

Lines 422 to 429 in b4344f7

def is_skipped_module(self, module_name):
"Return True if module_name matches any skip pattern."
if module_name is None: # some modules do not have names
return False
for pattern in self.skip:
if fnmatch.fnmatch(module_name, pattern):
return True
return False

📚 Documentation preview 📚: https://cpython-previews--141771.org.readthedocs.build/

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 19, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Nov 19, 2025
@gaogaotiantian gaogaotiantian merged commit e5adaaf into python:main Nov 20, 2025
41 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Nov 20, 2025
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@guoci @StanFromIreland
[Docs] Fix typo in bdb: is_skipped_line to is_skipped_module (pyt…
9c2e8c5 
…hon#141771)
ashm-dev pushed a commit to ashm-dev/cpython that referenced this pull request Dec 8, 2025
@guoci @ashm-dev
[Docs] Fix typo in bdb: is_skipped_line to is_skipped_module (pyt…
e5a79b4 
…hon#141771)
@guoci guoci deleted the patch-3 branch December 10, 2025 20:57
@guoci
Copy link
Contributor Author

guoci commented Dec 10, 2025

I think this needs backporting.

@gaogaotiantian gaogaotiantian added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 10, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 10, 2025

Thanks @guoci for the PR, and @gaogaotiantian for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

miss-islington-app bot commented Dec 10, 2025

Thanks @guoci for the PR, and @gaogaotiantian for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2025
@guoci @miss-islington
[Docs] Fix typo in bdb: is_skipped_line to is_skipped_module (pyt…
c395d7c 
…honGH-141771)

(cherry picked from commit e5adaaf)

Co-authored-by: Guo Ci <zguoci@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2025
@guoci @miss-islington
[Docs] Fix typo in bdb: is_skipped_line to is_skipped_module (pyt…
858a309 
…honGH-141771)

(cherry picked from commit e5adaaf)

Co-authored-by: Guo Ci <zguoci@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 10, 2025

GH-142547 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 10, 2025
@bedevere-app
Copy link

bedevere-app bot commented Dec 10, 2025

GH-142548 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 10, 2025
gaogaotiantian pushed a commit that referenced this pull request Dec 10, 2025
@miss-islington @guoci
[3.14] [Docs] Fix typo in bdb: is_skipped_line to `is_skipped_modul…
a160317 
…e` (GH-141771) (#142547)

[Docs] Fix typo in bdb: `is_skipped_line` to `is_skipped_module` (GH-141771)
(cherry picked from commit e5adaaf)

Co-authored-by: Guo Ci <zguoci@gmail.com>
gaogaotiantian pushed a commit that referenced this pull request Dec 10, 2025
@miss-islington @guoci
[3.13] [Docs] Fix typo in bdb: is_skipped_line to `is_skipped_modul…
3e48fbe 
…e` (GH-141771) (#142548)

[Docs] Fix typo in bdb: `is_skipped_line` to `is_skipped_module` (GH-141771)
(cherry picked from commit e5adaaf)

Co-authored-by: Guo Ci <zguoci@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaogaotiantian gaogaotiantian gaogaotiantian approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guoci @gaogaotiantian @StanFromIreland