Skip to content

GH-142305: JIT: Deduplicating GOT symbols in the trace #142316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
diegorusso merged 3 commits into from
Dec 10, 2025
Merged

GH-142305: JIT: Deduplicating GOT symbols in the trace #142316

diegorusso merged 3 commits into from
Dec 10, 2025

Conversation

@diegorusso
Copy link
Contributor

@diegorusso diegorusso commented Dec 5, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 5, 2025
Closed
@diegorusso diegorusso changed the title GH-142305: JIT: Deduplicating GOT symbols in the trace gh-142305: JIT: Deduplicating GOT symbols in the trace Dec 8, 2025
@diegorusso diegorusso changed the title gh-142305: JIT: Deduplicating GOT symbols in the trace GH-142305: JIT: Deduplicating GOT symbols in the trace Dec 8, 2025
savannahostrowski
savannahostrowski requested changes Dec 8, 2025
View reviewed changes
Copy link
Member

@savannahostrowski savannahostrowski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about the design choice!

Meta comment: man, I feel like GitHub has done this to me twice now where it's posted stale comments and/or eaten comments I've written during review...

@bedevere-app
Copy link

bedevere-app bot commented Dec 8, 2025

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

savannahostrowski
savannahostrowski reviewed Dec 8, 2025
View reviewed changes
savannahostrowski
savannahostrowski approved these changes Dec 10, 2025
View reviewed changes
@diegorusso diegorusso merged commit 4629567 into python:main Dec 10, 2025
78 of 80 checks passed
@diegorusso diegorusso deleted the got-symbols branch December 10, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savannahostrowski savannahostrowski savannahostrowski approved these changes

@markshannon markshannon Awaiting requested review from markshannon

@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@diegorusso @savannahostrowski