Skip to content

gh-142278: Add granular change detection for platforms in CI #142350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 3 commits into from
Dec 8, 2025
Merged

gh-142278: Add granular change detection for platforms in CI #142350

hugovk merged 3 commits into from
Dec 8, 2025

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Dec 6, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 6, 2025
Closed
@StanFromIreland StanFromIreland marked this pull request as ready for review December 6, 2025 15:55
hugovk
hugovk reviewed Dec 6, 2025
View reviewed changes
@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 6, 2025
@StanFromIreland @hugovk
Hugo's review
3133d2c 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
hugovk approved these changes Dec 8, 2025
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StanFromIreland @hugovk
Update Tools/build/compute-changes.py
c06a08c 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovk hugovk enabled auto-merge (squash) December 8, 2025 17:35
@hugovk
Copy link
Member

hugovk commented Dec 8, 2025

Let's also backport this, but wait a day or two before opening the backports, to check the logic is working as expected.

@hugovk hugovk merged commit 9e3d7cd into python:main Dec 8, 2025
122 of 126 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 8, 2025

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Dec 8, 2025

Sorry, @StanFromIreland and @hugovk, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9e3d7cdec156870a15b990f6a2d33f89539bd222 3.14

@miss-islington-app
Copy link

miss-islington-app bot commented Dec 8, 2025

Sorry, @StanFromIreland and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9e3d7cdec156870a15b990f6a2d33f89539bd222 3.13

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Dec 8, 2025

Sounds good, I do the cherry-picking.

@StanFromIreland StanFromIreland deleted the ci-plat branch December 8, 2025 18:06
brettcannon
brettcannon reviewed Dec 8, 2025
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this notes for she next PR that edits this file.

Tools/build/compute-changes.py
ANDROID_DIRS = frozenset({"Android"})
IOS_DIRS = frozenset({"Apple", "iOS"})
MACOS_DIRS = frozenset({"Mac"})
WASI_DIRS = frozenset({Path("Tools", "wasm")})
Copy link
Member

@brettcannon brettcannon Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically too broad as it includes Emscripten (since 3,14), but I don't think it's worth changing until the Platforms/ move happens.

Tools/build/compute-changes.py
print("GITHUB_OUTPUT not defined!")
return

with open(os.environ["GITHUB_OUTPUT"], "a", encoding="utf-8") as f:
Copy link
Member

@brettcannon brettcannon Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the naming being so consistent, this could be simplified with a for loop with https://docs.python.org/3/library/dataclasses.html#dataclasses.fields .

StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 10, 2025
@StanFromIreland @hugovk
[3.14] pythongh-142278: Add granular change detection for platforms i…
c02da5d 
…n CI (pythonGH-142350)

(cherry picked from commit 9e3d7cd)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 10, 2025

GH-142537 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 10, 2025
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 10, 2025
@StanFromIreland @hugovk
[3.13] pythongh-142278: Add granular change detection for platforms i…
832787a 
…n CI (pythonGH-142350)

(cherry picked from commit 9e3d7cd)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Dec 11, 2025
@StanFromIreland @hugovk
[3.14] gh-142278: Add granular change detection for platforms in CI (G…
b317c60 
…H-142350) (#142537)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 11, 2025
@StanFromIreland @hugovk
[3.13] pythongh-142278: Add granular change detection for platforms i…
8d3a959 
…n CI (pythonGH-142350)

(cherry picked from commit 9e3d7cd)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 11, 2025

GH-142578 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 11, 2025
hugovk added a commit that referenced this pull request Dec 11, 2025
@StanFromIreland @hugovk
[3.13] gh-142278: Add granular change detection for platforms in CI (G…
71bdb38 
…H-142350) (#142578)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon left review comments

@hugovk hugovk hugovk approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

@hugovk hugovk

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @hugovk @brettcannon