Skip to content

gh-140222: Increase stack margin on debug build #142452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 2 commits into from
Dec 9, 2025
Merged

gh-140222: Increase stack margin on debug build #142452

vstinner merged 2 commits into from
Dec 9, 2025

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Dec 9, 2025 •
edited by bedevere-app bot
Loading

Increase _PyOS_MIN_STACK_SIZE if Python is built in debug mode.

@vstinner
pythongh-140222: Increase stack margin on debug build
c667d06 
Increase _PyOS_MIN_STACK_SIZE if Python is built in debug mode.
@bedevere-app bedevere-app bot mentioned this pull request Dec 9, 2025
Closed
@vstinner
Copy link
Member Author

vstinner commented Dec 9, 2025

cc @encukou @markshannon @hroncok

On Fedora, we are building Python in debug mode with gcc -O0. I don't know how to detect that -O0 compiler option is used, but we can easily increase the stack margin if Python is built in debug mode (Py_DEBUG macro is defined) which is the case on Fedora.

I don't think that it's common to build Python in release mode without optimization, so checking for Py_DEBUG macro should be enough to fix the issue #140222.

@vstinner
Copy link
Member Author

vstinner commented Dec 9, 2025

"Tests / All required checks pass" job failed with:

Error: The template is not valid. .github/workflows/build.yml (Line: 715, Col: 24): Error reading JToken from JsonReader. Path '', line 0, position 0.

I'm not sure why :-(

@vstinner vstinner marked this pull request as draft December 9, 2025 14:52
markshannon
markshannon approved these changes Dec 9, 2025
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks.

@vstinner vstinner marked this pull request as ready for review December 9, 2025 15:22
@vstinner vstinner merged commit 49207a5 into python:main Dec 9, 2025
50 checks passed
@vstinner vstinner deleted the stack_margin branch December 9, 2025 15:25
@vstinner vstinner added the needs backport to 3.14 bugs and security fixes label Dec 9, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 9, 2025

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 9, 2025
@vstinner @miss-islington
pythongh-140222: Increase stack margin on debug build (pythonGH-142452)
68e2d1e 
Increase _PyOS_MIN_STACK_SIZE if Python is built in debug mode.
(cherry picked from commit 49207a5)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Dec 9, 2025

GH-142471 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 9, 2025
vstinner added a commit that referenced this pull request Dec 9, 2025
@miss-islington @vstinner
[3.14] gh-140222: Increase stack margin on debug build (GH-142452) (#…
04ecff5 
…142471)

gh-140222: Increase stack margin on debug build (GH-142452)

Increase _PyOS_MIN_STACK_SIZE if Python is built in debug mode.
(cherry picked from commit 49207a5)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @markshannon @ambv