gh-142466: Pixi package definitions for downstream use #142469
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
|
ping @FFY00 @hugovk @lysnikolaou |
|
You need to update the branch to fix the CI. |
- switch cases on `PYTHON_VARIANT` - remove `minor_version` by using `python3` - remove runtime-only asan options
Tools/pixi-packages/asan/recipe.yaml
Outdated
| @@ -0,0 +1,65 @@ | |||
| context: | |||
| # XXX: keep up to date | |||
There was a problem hiding this comment.
Re: https://discuss.python.org/t/cryptic-sequences-in-comments/38694
Can we replace all the "XXX" with "TODO" or something else? Maybe we don't even need it here:
| # XXX: keep up to date | |
| # Keep up to date |
If we do merge this, we have code in https://github.com/python/release-tools which is run during the first beta, when main becomes the next version, that updates a bunch of versions in the repo. And we can later update that to also update these versions.
There was a problem hiding this comment.
https://rattler-build.prefix.dev/latest/experimental_features/#load_from_filefile_path may remove the need for this
There was a problem hiding this comment.
Is there a YAML, TOML, or JSON file that contains the version @hugovk ? If not, could we add one?
There was a problem hiding this comment.
There isn't. Yes we can add one, it removes duplication here, and will be easier to programmatically update such a file.
There was a problem hiding this comment.
any preference for format / location / name?
There was a problem hiding this comment.
Sorry, I missed this because it was marked as resolved but I don't think it has been :)
Format: TOML or JSON, we can read using the stdlib.
Location: Tools/pixi-packages/, or Tools/ so other scripts can re-use it.
Name: Hmm, python-version.[ext] ?
There was a problem hiding this comment.
I think it was resolved for this PR via the third paragraph of #142469 (review)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
FFY00
left a comment
FFY00
left a comment
There was a problem hiding this comment.
Thanks so much for working on this @lucascolley! This is PR looks great, and sets up to add other sanitizer variants.
The pixi limitation that requires us to have separate recipes for each variant (prefix-dev/pixi#4599) is unfortunate, but I think doable from a maintenance POV, given that we have a few people interested in this. We'll see how it translates in practice, and hope the feature request gets implemented in the meantime.
I opened prefix-dev/rattler-build#2047 regarding the version string that currently needs to be updated manually, but could be dirtermined from git, with additional information. But let's wait for the pixi jinja functions to get stabilized before adding them to our recipes.
I'll leave this PR open a couple days to give a bit more time for folks to give feedback, but otherwise, this looks good to go 😊
|
Looks like nobody raised any issues 😊 Congrats @lucascolley! |
|
thanks a lot Filipe! |
…142469) * WIP: ENH: Pixi package definitions for downstream development [skip ci] * linux-64 support * tidy gitignore * respond to review - switch cases on `PYTHON_VARIANT` - remove `minor_version` by using `python3` - remove runtime-only asan options * README updates * use `.md` to preview rendering * Apply suggestions from code review Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> * Apply suggestion from @FFY00 Co-authored-by: Filipe Laíns <filipe.lains@gmail.com> * Apply suggestion from @FFY00 Co-authored-by: Filipe Laíns <filipe.lains@gmail.com> * Apply suggestion from @FFY00 Co-authored-by: Filipe Laíns <filipe.lains@gmail.com> * Apply suggestion from @lucascolley --------- Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
5 participants
implementation for gh-142466, supporting numpy/numpy#30381 and scipy/scipy#24066.