Skip to content

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented Dec 10, 2025

There was actually a much older issue in copy() were we didn't copy the block size. Considering no one has ever complained about this for the past 20 years, I think that no one is actually using copy() followed by .block_size somewhere... I will backport this as well to 3.13 and 3.14.

@picnixz
Copy link
Member Author

picnixz commented Dec 10, 2025

!buildbot FIPS-only

@bedevere-bot
Copy link

The regex 'FIPS-only' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@picnixz
Copy link
Member Author

picnixz commented Dec 10, 2025

!buildbot FIPS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @picnixz for commit cc591f8 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F142510%2Fmerge

The command will test the builders whose names match following regular expression: FIPS

The builders matched are:

  • AMD64 CentOS9 FIPS No Builtin Hashes PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR

@picnixz
Copy link
Member Author

picnixz commented Dec 10, 2025

Oh by the way, there is a separate issue with _hashlib itself. I don't know if it's really an issue though but in FIPS mode, not having HMAC means that... we are actually not importing _hashlib at all. I didn't think about it but it's because I used EVP_MAC_FETCH with a NULL fetch properties.

I'll fix this separately but this week-end.

@picnixz picnixz merged commit d3ef5ba into python:main Dec 14, 2025
50 of 52 checks passed
@picnixz picnixz deleted the fix/hashlib/hmac-copy-142451 branch December 14, 2025 08:45
@bedevere-app
Copy link

bedevere-app bot commented Dec 14, 2025

GH-142698 is a backport of this pull request to the 3.14 branch.

1 similar comment
@bedevere-app
Copy link

bedevere-app bot commented Dec 14, 2025

GH-142698 is a backport of this pull request to the 3.14 branch.

@bedevere-app
Copy link

bedevere-app bot commented Dec 14, 2025

GH-142701 is a backport of this pull request to the 3.13 branch.

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit d3ef5ba.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/12922) and take a look at the build logs.
  4. Check if the failure is related to this commit (d3ef5ba) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/12922

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 847, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=13 mode='wb' closefd=True>


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 847, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>

picnixz added a commit that referenced this pull request Dec 14, 2025
…-142510) (#142698)

Partially cherry-picked from d3ef5ba
which ensures that the `block_size` attribute exists on the copy.
picnixz added a commit that referenced this pull request Dec 14, 2025
…-142510) (#142701)

Partially cherry-picked from d3ef5ba
which ensures that the `block_size` attribute exists on the copy.
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 NoGIL 3.x (tier-2) has failed when building commit d3ef5ba.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1270/builds/6374) and take a look at the build logs.
  4. Check if the failure is related to this commit (d3ef5ba) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1270/builds/6374

Failed tests:

  • test_free_threading

Summary of the results of the build (if available):

==

Click to see traceback logs
remote: Enumerating objects: 13, done.        
remote: Counting objects:   9% (1/11)        
remote: Counting objects:  18% (2/11)        
remote: Counting objects:  27% (3/11)        
remote: Counting objects:  36% (4/11)        
remote: Counting objects:  45% (5/11)        
remote: Counting objects:  54% (6/11)        
remote: Counting objects:  63% (7/11)        
remote: Counting objects:  72% (8/11)        
remote: Counting objects:  81% (9/11)        
remote: Counting objects:  90% (10/11)        
remote: Counting objects: 100% (11/11)        
remote: Counting objects: 100% (11/11), done.        
remote: Compressing objects:  20% (1/5)        
remote: Compressing objects:  40% (2/5)        
remote: Compressing objects:  60% (3/5)        
remote: Compressing objects:  80% (4/5)        
remote: Compressing objects: 100% (5/5)        
remote: Compressing objects: 100% (5/5), done.        
remote: Total 13 (delta 6), reused 6 (delta 6), pack-reused 2 (from 2)        
From https://github.com/python/cpython
 * branch                    main       -> FETCH_HEAD
Note: switching to 'd3ef5ba34d3068b8178d6ff0f39462db6bbc4ad5'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at d3ef5ba34d3 gh-142451: correctly copy HMAC attributes in `HMAC.copy()` (#142510)
Switched to and reset branch 'main'

configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

make: *** [buildbottest] Error 2

fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants