bpo-39493: Fix definition of IO.closed in typing.py #18265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
approved these changes
Jan 30, 2020
|
@gvanrossum: Please replace |
Contributor
|
Thanks @hauntsaninja for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Contributor
|
Thanks @hauntsaninja for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Member
|
I'm guessing this deserves some backporting. |
|
GH-18273 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 30, 2020
(cherry picked from commit 2e6569b) Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
|
GH-18274 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 30, 2020
(cherry picked from commit 2e6569b) Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Jan 30, 2020
gvanrossum
added a commit
that referenced
this pull request
Jan 30, 2020
* bpo-39493: Fix definition of IO.closed in typing.py (GH-18265) (cherry picked from commit 2e6569b) Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com> * Use @absractproperty Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com> Co-authored-by: Guido van Rossum <guido@python.org>
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39493