Give proper credits for the memoryview implementation. #18626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncoghlan
approved these changes
Feb 23, 2020
Contributor
|
Thank you! :) |
|
@skrah: Please replace |
Contributor
Author
|
Thanks for taking a look! |
Contributor
|
Thanks @skrah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Contributor
|
Thanks @skrah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Contributor
|
I'm having trouble backporting to |
|
GH-18642 is a backport of this pull request to the 3.8 branch. |
Contributor
|
Thanks @skrah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-18643 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 24, 2020
(cherry picked from commit ee3bac4) Co-authored-by: Stefan Krah <skrah@bytereef.org>
sthagen
added a commit
to sthagen/python-cpython
that referenced
this pull request
Feb 24, 2020
Give proper credits for the memoryview implementation. (python#18626)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that people in the scientific ecosystem meticulously credit their contributions in source files, probably for good reason. :-)
cc @pitrou @ncoghlan in case I got something wrong.