Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 7, 2020

Remove obsolete workaround that prevented running files with
shortcuts when using new universal2 installers built on macOS 11.
Ignore buggy 2nd run_module_event call.
(cherry picked from commit 57e5113)

Co-authored-by: Terry Jan Reedy tjreedy@udel.edu

https://bugs.python.org/issue42508

Remove obsolete workaround that prevented running files with
shortcuts when using new universal2 installers built on macOS 11.
Ignore buggy 2nd run_module_event call.
(cherry picked from commit 57e5113)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@miss-islington
Copy link
Contributor Author

@terryjreedy and @ned-deily: Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington
Copy link
Contributor Author

@terryjreedy and @ned-deily: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@terryjreedy and @ned-deily: Status check is done, and it's a success ✅ .

@terryjreedy
Copy link
Member

terryjreedy commented Dec 7, 2020

Travis failure is unrelated but I don't know that it should be ignored. I restarted that one test.

# Regenerate Include/graminit.h and Python/graminit.c
# from Grammar/Grammar using pgen
PYTHONPATH=. python3 -m Parser.pgen ./Grammar/Grammar \
	./Grammar/Tokens \
	./Include/graminit.h.new \
	./Python/graminit.c.new
python3 ./Tools/clinic/clinic.py --make --srcdir .
  File "./Tools/clinic/clinic.py", line 1772
    filename_new = f"{filename}.new"
                                   ^
SyntaxError: invalid syntax
Makefile:574: recipe for target 'clinic' failed
make: *** [clinic] Error 1
make: *** Waiting for unfinished jobs....
python3 ./Tools/scripts/update_file.py ./Include/graminit.h ./Include/graminit.h.new
python3 ./Tools/scripts/update_file.py ./Python/graminit.c ./Python/graminit.c.new

@terryjreedy
Copy link
Member

Same error on rerun.

@terryjreedy terryjreedy requested review from ambv and ned-deily December 7, 2020 23:11
@terryjreedy
Copy link
Member

@ambv @ned-deily If the next 3.8 is going to have a macox11 installer, then this should be merged, (I believe Ned requested the backport.) But I don't know what to do about the repeated failure.

@ned-deily
Copy link
Member

@terryjreedy, you are not alone in seeing 3.8 CI failures, see https://bugs.python.org/issue42574. At the moment, support for macOS Big Sur / Apple Silicon has not yet been merged to 3.8 and I believe @ambv has decided to release 3.8.7rc1 without it. So this IDLE 3.8 backport is not critical yet, but we should plan on getting it in soon.

@terryjreedy terryjreedy merged commit d05b470 into python:3.8 Jan 5, 2021
@bedevere-bot
Copy link

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington miss-islington deleted the backport-57e5113-3.8 branch January 5, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants