Skip to content

bpo-44014: Fix error in Enum documentation.#25837

Merged
ambv merged 1 commit intopython:mainfrom
krisaoe:fix-docs-enum-reference
May 4, 2021
Merged

bpo-44014: Fix error in Enum documentation.#25837
ambv merged 1 commit intopython:mainfrom
krisaoe:fix-docs-enum-reference

Conversation

@krisaoe
Copy link
Copy Markdown
Contributor

@krisaoe krisaoe commented May 3, 2021 •
edited by bedevere-bot
Loading

Fix error in Enum documentation.

The example code was referring to the wrong enum Color, instead of Ordinal.

https://bugs.python.org/issue44014

@krisaoe krisaoe requested a review from ethanfurman as a code owner May 3, 2021 05:51
@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented May 3, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@krisaoe

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 3, 2021
tirkarthi
tirkarthi approved these changes May 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ambv
Copy link
Copy Markdown
Contributor

ambv commented May 4, 2021

Change trivial enough to not require CLA.

@ambv ambv merged commit 33d9bf2 into python:main May 4, 2021
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 4, 2021

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@ambv ambv added the needs backport to 3.10 only security fixes label May 4, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 4, 2021

Thanks @krisaoe for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 4, 2021
@krisaoe @miss-islington
Fix error in Enum documentation example code that was referring to th…
864697b 
…e wrong enum. (pythonGH-25837)

(cherry picked from commit 33d9bf2)

Co-authored-by: krisaoe <krisaoe@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 4, 2021

GH-25891 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 4, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 4, 2021

Thanks @krisaoe for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 4, 2021

Sorry, @krisaoe and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 33d9bf298b7672c5a09f8c0d80af00a4ec383e4a 3.9

@ambv ambv removed their assignment May 4, 2021
ambv pushed a commit that referenced this pull request May 4, 2021
@miss-islington @krisaoe
Fix error in Enum documentation example code that was referring to th…
31debfa 
…e wrong enum. (GH-25837) (#25891)

(cherry picked from commit 33d9bf2)

Co-authored-by: krisaoe <krisaoe@users.noreply.github.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@krisaoe @the-knights-who-say-ni @ambv @bedevere-bot @miss-islington @tirkarthi @ethanfurman