[3.8] bpo-40297: Fix test_socket.CANTest.testSendFrame (GH-19548)#25957
Merged
ambv merged 1 commit intopython:3.8from May 7, 2021
Merged
[3.8] bpo-40297: Fix test_socket.CANTest.testSendFrame (GH-19548)#25957ambv merged 1 commit intopython:3.8from
ambv merged 1 commit intopython:3.8from
Conversation
The address tuple for CAN_RAW no longer returns the address family after the introduction of CAN ISO-TP support in a30f6d4. However, updating test_socket.CANTest.testSendFrame was missed as part of the change, so the test incorrectly attempts to index past the last tuple item to retrieve the address family. This removes the now-redundant check for equality against socket.AF_CAN, as the tuple will not contain the address family. (cherry picked from commit 355bae8) Co-authored-by: karl ding <karlding@users.noreply.github.com>
Contributor
Author
Contributor
Author
Contributor
Author
Contributor
|
Note: while this is not a security bugfix per se, it enables us to use a wider array of buildbots to test 3.8 with, which is indirectly important for security. |
|
@ambv: Please replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The address tuple for CAN_RAW no longer returns the address family
after the introduction of CAN ISO-TP support in a30f6d4. However,
updating test_socket.CANTest.testSendFrame was missed as part of the
change, so the test incorrectly attempts to index past the last tuple
item to retrieve the address family.
This removes the now-redundant check for equality against socket.AF_CAN,
as the tuple will not contain the address family.
(cherry picked from commit 355bae8)
Co-authored-by: karl ding karlding@users.noreply.github.com
https://bugs.python.org/issue40297