Skip to content

gh-84530: fix namespace package support in modulefinder #29196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FFY00 merged 11 commits into from
Dec 9, 2025
Merged

gh-84530: fix namespace package support in modulefinder #29196

FFY00 merged 11 commits into from
Dec 9, 2025

Conversation

@FFY00
Copy link
Member

@FFY00 FFY00 commented Oct 23, 2021 •
edited by bedevere-app bot
Loading

@FFY00
bpo-40350: fix namespace package support in modulefinder
7610327 
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Copy link
Member Author

FFY00 commented Oct 23, 2021

__file__ is not set anymore. I don't know exactly which part of the code is responsible for that. Should we keep setting __file__, or is leaving it out fine?

@FFY00
consider that namespace package specs might have the loader set
23fb4e0 
Signed-off-by: Filipe Laíns <lains@riseup.net>
jaraco
jaraco reviewed Oct 31, 2021
View reviewed changes
jaraco
jaraco reviewed Oct 31, 2021
View reviewed changes
jaraco
jaraco reviewed Oct 31, 2021
View reviewed changes
@jaraco
Copy link
Member

jaraco commented Oct 31, 2021 •
edited
Loading

I see tests are failing. I suspect that's because the change modifies bootstrap_external but the C version hasn't been regenerated from it. I believe you need to run make regen-importlib to regenerate the C version of that module. It's been a while, so I only have 50% confidence in my understanding.

Edit: I ran make regen-importlib and nothing changed, so I guess that step isn't needed. I guess the test failures are actual test failures needing investigation.

@FFY00
Copy link
Member Author

FFY00 commented Oct 31, 2021

I am not home now, so I will finish up looking into the feedback later.

@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 1, 2021
@Tayodele
Copy link

Tayodele commented Apr 13, 2022

Any progress on this PR? I have run into the same issue and was wondering if this fix was coming anytime soon. I can take a look but I have never contributed so I don't really know how that works with a PR I didn't make myself.

@FFY00
Copy link
Member Author

FFY00 commented Apr 13, 2022

I will try to rebase the PR and fix the tests in the weekend.

@GregWhiteley GregWhiteley mannequin mentioned this pull request May 22, 2022
Open
@picnixz picnixz changed the title bpo-40350: fix namespace package support in modulefinder gh-84530: fix namespace package support in modulefinder Dec 3, 2024
@apdavison apdavison mentioned this pull request Apr 19, 2025
Open
brettcannon
brettcannon reviewed Sep 5, 2025
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the importlib changes look okay (no comment on the modulefinder changes).

FFY00 added 4 commits October 10, 2025 04:31
@FFY00
Merge remote-tracking branch 'origin/main' into bpo-40350
ffa7e31 
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Revert "consider that namespace package specs might have the loader set"
9a045fb 
This reverts commit 23fb4e0.

Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Fix load_module and load_package to handle namespace packages
87f9edb 
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Drop _NAMESPACE constant
755818b 
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Drop importlib changes
be926f8 
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Copy link
Member Author

FFY00 commented Oct 10, 2025

I rewrote the fix to drop the importlib changes.

merwok
merwok reviewed Nov 28, 2025
View reviewed changes
Lib/modulefinder.py Outdated
# On namespace packages, spec.loader might be None, but
# spec.submodule_search_locations should always be set — check it instead.
#
# TODO: Update the type check once GH-119669 is merged.
Copy link
Member

@merwok merwok Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be done now

Copy link
Member Author

@FFY00 FFY00 Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping 😊

FFY00 added 3 commits December 9, 2025 15:19
@FFY00
Merge branch 'main' into bpo-40350
78c4c48
@FFY00
Update NamespacePath check
8a864ca 
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Mixed some
3ca752b 
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Copy link
Member Author

FFY00 commented Dec 9, 2025

Since the importlib changes that previous raised concern have been removed, the fix is limited to modulefinder, and the test are passing, I think it should be okay to finally merge this PR.

@FFY00 FFY00 enabled auto-merge (squash) December 9, 2025 15:34
@FFY00 FFY00 merged commit 1b460fc into python:main Dec 9, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon left review comments

@jaraco jaraco jaraco left review comments

@merwok merwok merwok left review comments

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@warsaw warsaw Awaiting requested review from warsaw

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Assignees

No one assigned

Labels

stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@FFY00 @jaraco @Tayodele @brettcannon @merwok @the-knights-who-say-ni @ezio-melotti @bedevere-bot