(xml.dom.minidom.Document()).toxml() breakable

[iainlamb]

BPO	226866
Nosy	@freddrake

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/freddrake'
closed_at = <Date 2001-01-08.04:05:28.000>
created_at = <Date 2000-12-26.23:36:10.000>
labels = ['expert-XML']
title = '(xml.dom.minidom.Document()).toxml() breakable'
updated_at = <Date 2001-01-08.04:05:28.000>
user = 'https://bugs.python.org/iainlamb'

bugs.python.org fields:

activity = <Date 2001-01-08.04:05:28.000>
actor = 'fdrake'
assignee = 'fdrake'
closed = True
closed_date = None
closer = None
components = ['XML']
creation = <Date 2000-12-26.23:36:10.000>
creator = 'iainlamb'
dependencies = []
files = []
hgrepos = []
issue_num = 226866
keywords = []
message_count = 3.0
messages = ['2775', '2776', '2777']
nosy_count = 2.0
nosy_names = ['fdrake', 'iainlamb']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue226866'
versions = []

[iainlamb]

Consider this code:

from xml.dom.minidom import Document
import sys
e = Exception()
try:
	raise e
except:
	type = sys.exc_info()[0]
	d = Document()
	node = d.createTextNode(type)
	d.appendChild(node)
	print d.toxml()

It's derived from a case where I inadvertently passed a non-string
object (I was trying to represent the exception type) into
createTextNode(). Run it and you'll get:

Traceback (most recent call last):
  File "<stdin>", line 11, in ?
  File "c:\python\lib\xml\dom\minidom.py", line 83, in toxml
    self.writexml(writer)
  File "c:\python\lib\xml\dom\minidom.py", line 461, in writexml
    node.writexml(writer)
  File "c:\python\lib\xml\dom\minidom.py", line 400, in writexml
    _write_data(writer, self.data)
  File "c:\python\lib\xml\dom\minidom.py", line 153, in _write_data
    data = string.replace(data, "&", "&amp;")
  File "c:\python\lib\string.py", line 363, in replace
    return s.replace(old, new, maxsplit)
AttributeError: replace

I suggest you convert the text node's contents to a string before
making the call to string.replace() in minidom.py

Thanks for a cool dom implementation!

• Iain Lamb

[freddrake]

This will be fairly easy to fix; look for me to check it in early next week (when I'm near a real workstation!).

[freddrake]

Fixed in Lib/xml/dom/minidom.py revision 1.19.
If the parameter is not an 8-bit or Unicode string, TypeError is raised.