zipfile and big zipped file

[keyphrene]

BPO	992750
Nosy	@loewis
Files	zipfile.py.diff: readFile

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2007-02-13.09:01:20.000>
created_at = <Date 2004-07-17.07:45:39.000>
labels = ['library']
title = 'zipfile and big zipped file'
updated_at = <Date 2007-02-13.09:01:20.000>
user = 'https://bugs.python.org/keyphrene'

bugs.python.org fields:

activity = <Date 2007-02-13.09:01:20.000>
actor = 'loewis'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2004-07-17.07:45:39.000>
creator = 'keyphrene'
dependencies = []
files = ['6092']
hgrepos = []
issue_num = 992750
keywords = ['patch']
message_count = 5.0
messages = ['46379', '46380', '46381', '46382', '46383']
nosy_count = 3.0
nosy_names = ['loewis', 'alanmcintyre', 'keyphrene']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue992750'
versions = ['Python 2.3']

[keyphrene]

read method decompress the zipped files, but this
method returns bytes, more the file is big, more the
bytes array is big. readFile method allows to send the
bytes in a file.

[loewis]

Logged In: YES
user_id=21627

The patch is unacceptable in its current form. It duplicates
too much code; read and readfile should really share the
common code (e.g. by read falling back to readfile).

Also, as this really copies the data to fileobj, it probably
is better called copyfile, instead of readfile.

Finally, I would much prefer if zipfile would have an .open
method, returning a file-like object. Then you would have
such implementations

  def read(self, name):
      return self.open(name, "r").read()

  def readfile(self, name, dest):
      import shutil
      shutil.copyfileobj(self.open(name,"r"), dest)

I would then probably leave the last method out, and
encourage users to invoke shutil.copyfileobj directly if
desired.

Are you willing to make changes in this direction?

[alanmcintyre]

Logged In: YES
user_id=1115903

The current behavior of ZipFile.read is an occasional
annoyance for me. I will make the changes described in
loewis' comments and submit the updated patch, unless
somebody is already working on it.

[alanmcintyre]

Logged In: YES
user_id=1115903

Ok, I ended up just starting from scratch and implementing a
file-like class - it just implements read([size]) right now

• and an instance of this class is returned when you call
  ZipFile.open. ZipFile.read was modified to use open(), as
  loewis suggested. I also added some code to test_zipfile.py
  to check the new open function, and tried using it to
  extract a 690MB file from a ZIP with copyfileobj. It seems
  to be working ok.

Since I can't get into CVS at the moment, I don't have diff
files to post. Even if I did, I don't see an option for me
to post them to this patch. Should I post them as a new patch?

[loewis]

It seems that this patch was superceded by 1121142, so closing it as out-of-date.