Fails assertion in winsig.c under VC 8.0

[timothyfitz]

BPO	1167262
Nosy	@mwhudson, @loewis

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2005-11-28.17:36:13.000>
created_at = <Date 2005-03-21.03:25:59.000>
labels = ['library']
title = 'Fails assertion in winsig.c under VC 8.0'
updated_at = <Date 2005-11-28.17:36:13.000>
user = 'https://bugs.python.org/timothyfitz'

bugs.python.org fields:

activity = <Date 2005-11-28.17:36:13.000>
actor = 'loewis'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2005-03-21.03:25:59.000>
creator = 'timothyfitz'
dependencies = []
files = []
hgrepos = []
issue_num = 1167262
keywords = []
message_count = 6.0
messages = ['24723', '24724', '24725', '24726', '24727', '24728']
nosy_count = 4.0
nosy_names = ['mwh', 'loewis', 'varmaa', 'timothyfitz']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1167262'
versions = ['Python 2.5']

[timothyfitz]

In 2.4 and current cvs initsignal in signalmodule.c calls
PyOS_getsig which calls signal with an invalid signal
number. Under VC 7.1 (and 7.0, and probably before)
this would return SIG_ERR however under VC 8.0 (beta)
this causes an assertion failure.

[mwhudson]

Logged In: YES
user_id=6656

Ew. My first thought is, is that allowed by ANSI C? I'd guess it's
undefined behaviour. It still seems excessively unfriendly -- have you
reported this to MS?

[loewis]

Logged In: YES
user_id=21627

C99 7.14.1.1/p8 specifies

# If the request can be honored, the signal function
# returns the value of func for the most recent successful
# call to signal for the specified signal sig. Otherwise, a
# value of SIG_ERR is returned and a positive value is stored
# in errno.

So it seems to me that VC8 is in error: the request cannot
be "honored", so it should return SIG_ERR. Until/if VC8 is
released with that bug, I would like to take no action here.
When it is released, we still might consider to ignore it until
say, 8.1 comes along and fixes the bug.

[loewis]

Logged In: YES
user_id=21627

See bpo-1311784 for more discussion of this problem.

[varmaa]

Logged In: YES
user_id=863202

Just wanted to mention that the Visual Studio 2005 products
were officially launched on November 7th, 2005, and this
same problem occurs when compiling the Python 2.4 source
using Visual C++ 2005 Express Edition.

[loewis]

Logged In: YES
user_id=21627

This is now fixed with patch bpo-1350409.