struni: Replace assert_(==) with failUnlessEqual

[tiran]

BPO	1751515
Nosy	@gvanrossum, @tiran
Files	newpatch.diff: new patch - more conservative and manually checked

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/gvanrossum'
closed_at = <Date 2008-01-06.22:29:45.945>
created_at = <Date 2007-07-10.22:25:12.000>
labels = ['tests']
title = 'struni: Replace assert_(==) with failUnlessEqual'
updated_at = <Date 2008-01-06.22:29:45.945>
user = 'https://github.com/tiran'

bugs.python.org fields:

activity = <Date 2008-01-06.22:29:45.945>
actor = 'admin'
assignee = 'gvanrossum'
closed = True
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2007-07-10.22:25:12.000>
creator = 'christian.heimes'
dependencies = []
files = ['8076']
hgrepos = []
issue_num = 1751515
keywords = ['patch']
message_count = 4.0
messages = ['52820', '52821', '52822', '52823']
nosy_count = 2.0
nosy_names = ['gvanrossum', 'christian.heimes']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1751515'
versions = ['Python 3.0']

[tiran]

Patch for py3k-struni branch

It replaces assert_(foo == bar) and failUnless(foo == bar) with failUnlessEqual(foo, bar). It makes debugging the error MUCH easier to see both values.

[tiran]

File Added: newpatch.diff

[gvanrossum]

check it in!

[gvanrossum]

Sorry, that was meant for another patch.

I've checked this one in now, after changing failUnlessEqual with assertEqual (the double negative trips me up in reading code using failUnlessXXX all the time).