Use allowZip64=True by default

[serhiy-storchaka]

BPO	17201
Nosy	@loewis, @pitrou, @serhiy-storchaka
Files	zipfile_zip64_by_default.patch zipfile_zip64_by_default.patch: updated more unit tests

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2013-11-23.13:57:50.944>
created_at = <Date 2013-02-13.17:04:32.313>
labels = ['easy', 'type-feature', 'library']
title = 'Use allowZip64=True by default'
updated_at = <Date 2014-03-10.01:35:02.798>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2014-03-10.01:35:02.798>
actor = 'python-dev'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2013-11-23.13:57:50.944>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2013-02-13.17:04:32.313>
creator = 'serhiy.storchaka'
dependencies = []
files = ['29074', '29075']
hgrepos = []
issue_num = 17201
keywords = ['patch', 'easy']
message_count = 9.0
messages = ['182048', '182063', '182101', '182114', '182139', '196480', '204017', '204019', '213005']
nosy_count = 7.0
nosy_names = ['loewis', 'alanmcintyre', 'pitrou', 'python-dev', 'william.mallard', 'Ramchandra Apte', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17201'
versions = ['Python 3.4']

[serhiy-storchaka]

Python supports ZIP64 extension since 2.5 (more 6 years ago). May be it is time to use it by default, leaving the option to disable it by specifying allowZip64=False.

[williammallard]

Enabling ZIP64 seems like a reasonable default.

The documentation justifies the current 32-bit default with outdated information:
"""
ZIP64 extensions are disabled by default because the default 'zip' and 'unzip' commands on Unix (the InfoZIP utilities) don't support these extensions.
"""

But InfoZIP has supported the ZIP64 extension for 4 years (since UnZip 6.0, and Zip 3.0).

[pitrou]

+1. Let's make it for 3.4.

[williammallard]

See attached. The patch updates ZipFile, its documentation, and its unit tests.

[RamchandraApte]

LGTM.

[serhiy-storchaka]

The patch LGTM. If anyone has objections, say them now.

[python-dev]

New changeset 271cc3660445 by Serhiy Storchaka in branch 'default':
Issue bpo-17201: ZIP64 extensions now are enabled by default.
http://hg.python.org/cpython/rev/271cc3660445

[serhiy-storchaka]

Thank you William for your contribution.

[python-dev]

New changeset 86338438b70d by R David Murray in branch 'default':
whatsnew: allowZip64 defaults to True (bpo-17201).
http://hg.python.org/cpython/rev/86338438b70d