sqlite3 Row can return duplicate keys when using adapters

[BreamoreBoy]

BPO	21465
Nosy	@berkerpeksag, @tirkarthi, @erlend-aasland

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-08-05.10:59:35.648>
created_at = <Date 2014-05-09.21:50:56.660>
labels = ['invalid', 'type-bug', 'library']
title = 'sqlite3 Row can return duplicate keys when using adapters'
updated_at = <Date 2021-08-05.10:59:35.647>
user = 'https://bugs.python.org/BreamoreBoy'

bugs.python.org fields:

activity = <Date 2021-08-05.10:59:35.647>
actor = 'erlendaasland'
assignee = 'none'
closed = True
closed_date = <Date 2021-08-05.10:59:35.648>
closer = 'erlendaasland'
components = ['Library (Lib)']
creation = <Date 2014-05-09.21:50:56.660>
creator = 'BreamoreBoy'
dependencies = []
files = []
hgrepos = []
issue_num = 21465
keywords = []
message_count = 3.0
messages = ['218200', '393933', '398993']
nosy_count = 3.0
nosy_names = ['berker.peksag', 'xtreak', 'erlendaasland']
pr_nums = []
priority = 'normal'
resolution = 'not a bug'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue21465'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']

[BreamoreBoy]

Code adopted from here https://docs.python.org/3/library/sqlite3.html#default-adapters-and-converters.

import sqlite3
import datetime

con = sqlite3.connect(":memory:", detect_types=sqlite3.PARSE_DECLTYPES|sqlite3.PARSE_COLNAMES)
con.row_factory = sqlite3.Row
cur = con.cursor()
cur.execute("create table test(d date, ts timestamp)")

today = datetime.date.today()
now = datetime.datetime.now()

cur.execute("insert into test(d, ts) values (?, ?)", (today, now))

cur.execute('select current_date as "d [date]", current_timestamp as "ts [timestamp]"')
row = cur.fetchone()
print(row.keys())

cur.execute('select current_date as "nit [date]", current_timestamp as "nit [timestamp]"')
row = cur.fetchone()
print(row.keys())

cur.execute('select current_date as " [date]", current_timestamp as " [timestamp]"')
row = cur.fetchone()
print(row.keys())

Output ---

c:\Users\Mark\MyPython>sqlite3_error.py
['d', 'ts']
['nit', 'nit']
['', '']

This clearly defeats the purpose of using keys to access the given columns. Hardly a show stopper but I thought I'd flag it up.

[erlend-aasland]

AFAICS, this has nothing to do with adapters; you'll get duplicate keys just by executing 'select 1 as "token", 2 as "token"'. If you want the columns to have unique names, you should assign them unique names.

At most, there could be a sentence about this in the docs ("best practices"), but IMO this should be obvious. I would leave the docs as they are.

Suggesting to close this as not a bug.

[erlend-aasland]

Closing this for now. If anyone disagrees, please reopen :)