-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
bpo-34179: Make sure decimal context doesn't affect other tests #8376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
skrah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch. In this case I would not make a NEWS entry, since the change does not affect users.
This reverts commit d1b6de7.
|
I've reverted the NEWS entry - I never know whether to add one. |
|
Yes, the bots aren't very flexible and NEWS entries somewhat subject to personal taste. I usually add one if I'd really want to be informed as a user, other people practically always add one. |
|
@skrah: Please replace |
…honGH-8376) (cherry picked from commit 938045f) Co-authored-by: Bo Bayles <bbayles@gmail.com>
|
GH-8383 is a backport of this pull request to the 3.7 branch. |
…honGH-8376) (cherry picked from commit 938045f) Co-authored-by: Bo Bayles <bbayles@gmail.com>
|
GH-8384 is a backport of this pull request to the 3.6 branch. |
The use of
decimal.getcontextintest_time.pyaffects other modules that use thedecimalmodule.The PR changes the tests to use
decimal.localcontext, which doesn't have this problem.After
Before
https://bugs.python.org/issue34179