Skip to content

[3.9] gh-91118: Fix docstrings that do not honor --without-doc-strings (GH-31769) #91664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2022
Merged

[3.9] gh-91118: Fix docstrings that do not honor --without-doc-strings (GH-31769) #91664

merged 2 commits into from
Apr 19, 2022

Conversation

@arhadthedev
Copy link
Member

@arhadthedev arhadthedev commented Apr 18, 2022

Co-authored-by: Éric merwok@netwok.org
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com
(cherry picked from commit a573cb2)

Co-authored-by: Oleg Iarygin oleg@arhadthedev.net

@arhadthedev @merwok @JelleZijlstra
pythongh-91118: Fix docstrings that do not honor --without-doc-strings (
1c97e4b 
python#31769)

Co-authored-by: Éric <merwok@netwok.org>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit a573cb2)
@arhadthedev arhadthedev mentioned this pull request Apr 18, 2022
Merged
@JelleZijlstra JelleZijlstra self-requested a review April 18, 2022 14:26
@JelleZijlstra JelleZijlstra self-assigned this Apr 18, 2022
JelleZijlstra
JelleZijlstra requested changes Apr 18, 2022
View reviewed changes
Objects/unionobject.c Outdated
@@ -0,0 +1,492 @@
// types.UnionType -- used to represent e.g. Union[int, str], int | str
Copy link
Member

@JelleZijlstra JelleZijlstra Apr 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you accidentally added this file

@bedevere-bot
Copy link

bedevere-bot commented Apr 18, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@arhadthedev
Copy link
Member Author

arhadthedev commented Apr 19, 2022

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Apr 19, 2022

Thanks for making the requested changes!

@JelleZijlstra: please review the changes made to this pull request.

@JelleZijlstra JelleZijlstra merged commit 312e16f into python:3.9 Apr 19, 2022
@JelleZijlstra
Copy link
Member

JelleZijlstra commented Apr 19, 2022

Thank you!

@arhadthedev arhadthedev deleted the backport-a573cb2-3.9 branch April 19, 2022 20:17
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@arhadthedev @merwok
@JelleZijlstra @hello-adam
[3.9] pythongh-91118: Fix docstrings that do not honor --without-doc-…
bcea942 
…strings (pythonGH-31769) (python#91664)

Co-authored-by: Éric <merwok@netwok.org>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit a573cb2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arhadthedev @bedevere-bot @JelleZijlstra