gh-92082: Changed a.closing from a class to a function for consistency with docs#92155
Merged
JelleZijlstra merged 1 commit intopython:mainfrom May 2, 2022
Merged
Conversation
Signed-off-by: prwatson <prwatson@redhat.com>
|
All commit authors signed the Contributor License Agreement. |
|
Every change to Python requires a NEWS entry. Please, add it using the blurb_it Web app or the blurb command-line tool. |
JelleZijlstra
changed the title
JelleZijlstra
approved these changes
May 2, 2022
Contributor
|
Thanks @Thaddeus1499 for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-92163 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 2, 2022
…nction for consistency (pythonGH-92155) Signed-off-by: prwatson <prwatson@redhat.com> (cherry picked from commit 958f21c) Co-authored-by: Thaddeus1499 <104600742+Thaddeus1499@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: prwatson prwatson@redhat.com
gh-92082: Changed aclosing from a class to a function as closing is listed as a function.
aclosing was originally listed as class, however, this is inconsistent as closing is listed as a function right above it. aclosing has been changed from a class to a function.