gh-90978: test_ssl of test_asyncio uses LONG_TIMEOUT#92402
Merged
pablogsal merged 1 commit intopython:mainfrom May 6, 2022
vstinner:test_asyncio_ssl_timeout
Merged
gh-90978: test_ssl of test_asyncio uses LONG_TIMEOUT#92402pablogsal merged 1 commit intopython:mainfrom vstinner:test_asyncio_ssl_timeout
pablogsal merged 1 commit intopython:mainfrom
vstinner:test_asyncio_ssl_timeout
Conversation
On slow buildbot workers, some test_ssl tests fail randomly because of short timeout (30 seconds). Use support.LONG_TIMEOUT instead which is longer and also adjusted (by regrtest --timeout option) on buildbot workers known to be slow.
Member
Author
|
Python 3.10 already uses LONG_TIMEOUT: |
Member
Author
|
cc @zooba |
Member
Author
|
There is no need to backport the change to Python 3.10. In Python 3.10, it's a different filename and it already uses LONG_TIMEOUT. |
Member
Author
|
@pablogsal: Here is a fix for the x86 Gentoo buildbot. |
pablogsal
approved these changes
May 6, 2022
Member
Author
|
test_asyncio.test_create_server_ssl_over_ssl() failed on x86 Gentoo Non-Debug with X 3.x: https://buildbot.python.org/all/#/builders/58/builds/2300 IMO the problem is the hardcoded timeout of 30 seconds. This change increases it to 5 minutes (or longer, it's adapted to the buidbot --timeout argument). |
asvetlov
approved these changes
May 6, 2022
Contributor
asvetlov
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On slow buildbot workers, some test_ssl tests fail randomly because
of short timeout (30 seconds). Use support.LONG_TIMEOUT instead which
is longer and also adjusted (by regrtest --timeout option) on
buildbot workers known to be slow.