gh-51524: Fix bug when calling trace.CoverageResults with valid infile #99629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furkanonder
changed the title
furkanonder
requested review from
a team,
AlexWaygood,
Fidget-Spinner,
JelleZijlstra,
abalkin,
berkerpeksag,
brettcannon,
cjw296,
encukou,
ericsnowcurrently,
ericvsmith,
erlend-aasland,
ethanfurman,
ezio-melotti,
gpshead,
gvanrossum,
isidentical,
lysnikolaou,
ncoghlan,
pablogsal,
pganssle,
rhettinger,
terryjreedy and
warsaw
as code owners
AlexWaygood
removed request for
1st1,
asvetlov,
brandtbucher,
markshannon and
methane
terryjreedy
reviewed
Nov 20, 2022
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
Approved with minor edit and addition of blurb. Does following seen sufficient?
Fix bug when calling trace.CoverageResults with valid infile.
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Contributor
Author
|
@terryjreedy I have made the requested changes. Can you review it again? |
furkanonder
requested review from
terryjreedy
and removed request for
iritkatriel
gvanrossum
changed the title
terryjreedy
added
type-bug
Contributor
|
Thanks @furkanonder for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-99832 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 28, 2022
… infile (pythonGH-99629) (cherry picked from commit 594de16) Co-authored-by: Furkan Onder <furkanonder@protonmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 28, 2022
… infile (pythonGH-99629) (cherry picked from commit 594de16) Co-authored-by: Furkan Onder <furkanonder@protonmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-99833 is a backport of this pull request to the 3.10 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.