Skip to content

gh-101372: Fix unicodedata.is_normalized to properly handle the UCD 3… #101388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 6, 2023
Merged

gh-101372: Fix unicodedata.is_normalized to properly handle the UCD 3… #101388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3cc6f06
gh-101372: Fix unicodedata.is_normalized to properly handle the UCD 3…
corona10 Jan 28, 2023
9e663af
Rename the test
corona10 Jan 28, 2023
d8edb54
Sampling test sets
corona10 Jan 28, 2023
080b6cc
Add multi multicharacter case
corona10 Jan 28, 2023
c197665
Address code review
corona10 Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2023-01-28-20-31-42.gh-issue-101372.8BcpCC.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix :func:`~unicodedata.is_normalized` to properly handle the UCD 3.2.0
cases. Patch by Dong-hee Na.
2 changes: 1 addition & 1 deletion Modules/unicodedata.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,7 +800,7 @@ is_normalized_quickcheck(PyObject *self, PyObject *input, bool nfc, bool k,
{
/* UCD 3.2.0 is requested, quickchecks must be disabled. */
if (UCD_Check(self)) {
return NO;
return MAYBE;
}

if (PyUnicode_IS_ASCII(input)) {
Expand Down