gh-101973: Fix parameter reference for PyModule_FromDefAndSpec #101976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
approved these changes
Feb 17, 2023
erlend-aasland
added
needs backport to 3.10
erlend-aasland
changed the title
Contributor
|
Thanks @arhadthedev for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 17, 2023
…ythonGH-101976) (cherry picked from commit a3bb7fb) Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
|
GH-101982 is a backport of this pull request to the 3.11 branch. |
|
GH-101983 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 17, 2023
…ythonGH-101976) (cherry picked from commit a3bb7fb) Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
miss-islington
added a commit
that referenced
this pull request
Feb 17, 2023
miss-islington
added a commit
that referenced
this pull request
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative, we can rename the parameter itself, from def to moduleDef.