Skip to content

gh-103202: Proof of concept: OrderedDict.sort() #103203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

gh-103202: Proof of concept: OrderedDict.sort() #103203

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33c8adf
Implement OrderedDict.sort
Gouvernathor Apr 3, 2023
61264d5
Fix typo
Gouvernathor Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Lib/collections/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,28 @@ def move_to_end(self, key, last=True):
first.prev = soft_link
root.next = link

def sort(self, /, **kwargs):
if len(self) < 2:
return

root = link_prev = self.__root
map = self.__map

links = []
for key in sorted(self, **kwargs):
link = map[k]
soft_link = link.next.prev
links.append((link, soft_link))

for link, soft_link in links:
link.prev = link_prev
link_prev.next = link

link_prev = soft_link

link.next = root
root.prev = soft_link

def __sizeof__(self):
sizeof = _sys.getsizeof
n = len(self) + 1 # number of links including root
Expand Down