Skip to content

gh-105375: Improve error handling in the builtins extension module #105585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2023
Merged

gh-105375: Improve error handling in the builtins extension module #105585

merged 1 commit into from
Jun 11, 2023

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 9, 2023 •
edited by bedevere-bot
Loading

@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 9, 2023
Closed
18 tasks
@erlend-aasland erlend-aasland requested a review from sobolevn June 9, 2023 20:46
sobolevn
sobolevn approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erlend-aasland erlend-aasland merged commit d4fa529 into python:main Jun 11, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jun 11, 2023

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the improve-bltin-error-handling branch June 11, 2023 10:20
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
@erlend-aasland @miss-islington
pythongh-105375: Improve error handling in the builtins extension mod…
e49876d 
…ule (pythonGH-105585)

(cherry picked from commit d4fa529)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jun 11, 2023

GH-105649 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
@erlend-aasland @miss-islington
pythongh-105375: Improve error handling in the builtins extension mod…
dfa27ee 
…ule (pythonGH-105585)

(cherry picked from commit d4fa529)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 11, 2023
@bedevere-bot
Copy link

bedevere-bot commented Jun 11, 2023

GH-105650 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 11, 2023
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
@miss-islington @erlend-aasland
[3.11] gh-105375: Improve error handling in the builtins extension mo…
b3d95d4 
…dule (GH-105585) (#105650)

(cherry picked from commit d4fa529)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
@miss-islington @erlend-aasland
[3.12] gh-105375: Improve error handling in the builtins extension mo…
122a1a2 
…dule (GH-105585) (#105649)

(cherry picked from commit d4fa529)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @miss-islington @bedevere-bot @sobolevn