gh-105993: Add possible None return type to start_tls() docs #105995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dreamsorcerer
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
gvanrossum
approved these changes
Jun 28, 2023
Member
|
I think this is precise enough. We should backport to several past revisions. @kumaraditya303 Do you agree? |
gvanrossum
added
needs backport to 3.11
kumaraditya303
approved these changes
Jun 28, 2023
Contributor
Let's try to backport till 3.10. |
Contributor
|
Thanks @Dreamsorcerer for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12. |
|
GH-106188 is a backport of this pull request to the 3.12 branch. |
|
GH-106189 is a backport of this pull request to the 3.11 branch. |
|
GH-106190 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 28, 2023
…p.start_tls` docs (pythonGH-105995) (cherry picked from commit 6b52a58) Co-authored-by: Sam Bull <git@sambull.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 28, 2023
…p.start_tls` docs (pythonGH-105995) (cherry picked from commit 6b52a58) Co-authored-by: Sam Bull <git@sambull.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 28, 2023
…p.start_tls` docs (pythonGH-105995) (cherry picked from commit 6b52a58) Co-authored-by: Sam Bull <git@sambull.org>
kumaraditya303
pushed a commit
that referenced
this pull request
Jun 28, 2023
kumaraditya303
pushed a commit
that referenced
this pull request
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to edit and make it more precise, I'm not too clear exactly when
Nonecan or can't occur.📚 Documentation preview 📚: https://cpython-previews--105995.org.readthedocs.build/