Skip to content

Refer to TimeoutError instead of asyncio.TimeoutError in asyncio-task.rst #106136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 28, 2023
Merged

Refer to TimeoutError instead of asyncio.TimeoutError in asyncio-task.rst #106136

merged 5 commits into from
Jun 28, 2023

Conversation

@lightdrk
Copy link
Contributor

@lightdrk lightdrk commented Jun 27, 2023 •
edited
Loading

correction of reference , asyncio.TimeoutError to TimeoutError .
(asyncio: Confusing TimeoutError #106068 )

📚 Documentation preview 📚: https://cpython-previews--106136.org.readthedocs.build/

@lightdrk
Update asyncio-task.rst
da999e5 
correction of reference , asyncio.TimeoutError to  TimeoutError .
@ghost
Copy link

ghost commented Jun 27, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jun 27, 2023
@arhadthedev arhadthedev changed the title Update asyncio-task.rst Refer to TimeoutError instead of asyncio.TimeoutError in asyncio-task.rst Jun 27, 2023
gvanrossum
gvanrossum requested changes Jun 27, 2023
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented Jun 27, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@lightdrk
Copy link
Contributor Author

lightdrk commented Jun 27, 2023

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Jun 27, 2023

Thanks for making the requested changes!

@gvanrossum: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from gvanrossum June 27, 2023 17:48
hugovk
hugovk requested changes Jun 27, 2023
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented Jun 27, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

lightdrk and others added 2 commits June 27, 2023 23:26
@lightdrk @hugovk
Update Doc/library/asyncio-task.rst
e43e355 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@lightdrk @hugovk
Update Doc/library/asyncio-task.rst
b687b77 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@lightdrk
Copy link
Contributor Author

lightdrk commented Jun 28, 2023

I have made the requested changes; please review

@gvanrossum
Copy link
Member

gvanrossum commented Jun 28, 2023

@hugovk Can you land it once you're happy with it?

@lightdrk (and @hugovk) Next time try to make the commit titles a bit more meaningful please. :-)

@lightdrk
Copy link
Contributor Author

lightdrk commented Jun 28, 2023

@hugovk Can you land it once you're happy with it?

@lightdrk (and @hugovk) Next time try to make the commit titles a bit more meaningful please. :-)

Yep, first time contributing , I will, Thanks .

@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 28, 2023
hugovk
hugovk approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@hugovk hugovk merged commit 541a10f into python:main Jun 28, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jun 28, 2023

Thanks @lightdrk for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 28, 2023
@lightdrk @hugovk @miss-islington
Refer to TimeoutError instead of asyncio.TimeoutError in `asyncio…
2437761 
…-task.rst` (pythonGH-106136)

(cherry picked from commit 541a10f)

Co-authored-by: lightdrk <108566237+lightdrk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Jun 28, 2023

GH-106179 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 28, 2023
@bedevere-bot
Copy link

bedevere-bot commented Jun 28, 2023

GH-106180 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 28, 2023
@lightdrk @hugovk @miss-islington
Refer to TimeoutError instead of asyncio.TimeoutError in `asyncio…
ac4cb56 
…-task.rst` (pythonGH-106136)

(cherry picked from commit 541a10f)

Co-authored-by: lightdrk <108566237+lightdrk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 28, 2023
hugovk added a commit that referenced this pull request Jun 28, 2023
@miss-islington @lightdrk @hugovk
[3.12] Refer to TimeoutError instead of asyncio.TimeoutError in `…
56e3919 
…asyncio-task.rst` (GH-106136) (#106179)

Co-authored-by: lightdrk <108566237+lightdrk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Jun 28, 2023
@miss-islington @lightdrk @hugovk
[3.11] Refer to TimeoutError instead of asyncio.TimeoutError in `…
2cce465 
…asyncio-task.rst` (GH-106136) (#106180)

Co-authored-by: lightdrk <108566237+lightdrk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovk hugovk mentioned this pull request Jun 28, 2023
Closed
@lightdrk lightdrk deleted the version-3.11 branch June 28, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lightdrk @bedevere-bot @gvanrossum @miss-islington @hugovk @arhadthedev