Skip to content

Remove unused Py_XDECREF from _PyFrame_ClearExceptCode #106158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2024
Merged

Remove unused Py_XDECREF from _PyFrame_ClearExceptCode #106158

merged 2 commits into from
Feb 1, 2024
+0 −1

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Jun 27, 2023

frame->frame_obj was set to NULL a few lines earlier.

@andersk
Remove unused Py_XDECREF from _PyFrame_ClearExceptCode
2ff57f8 
frame->frame_obj was set to NULL a few lines earlier.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@Eclips4
Copy link
Member

Eclips4 commented Jun 27, 2023

Although PY_XDECREF is intended as PY_DECREF with a check on NULL value, I think this change makes sense.

@serhiy-storchaka serhiy-storchaka merged commit 84e0e32 into python:main Feb 1, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@andersk @aisk
Remove unused Py_XDECREF from _PyFrame_ClearExceptCode (pythonGH-106158)
c4ec2a4 
frame->frame_obj was set to NULL a few lines earlier.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andersk @Eclips4 @serhiy-storchaka @arhadthedev @bedevere-bot