Skip to content

gh-104683: clinic.py: Don't needlessly reimplement contextlib.redirect_stdout #106478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2023
Merged

gh-104683: clinic.py: Don't needlessly reimplement contextlib.redirect_stdout #106478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1617,19 +1617,6 @@ def render_function(
return clinic.get_destination('block').dump()




@contextlib.contextmanager
def OverrideStdioWith(stdout):
saved_stdout = sys.stdout
sys.stdout = stdout
try:
yield
finally:
assert sys.stdout is stdout
sys.stdout = saved_stdout


def create_regex(
before: str,
after: str,
Expand Down Expand Up @@ -2331,17 +2318,14 @@ def compute_checksum(
return s




class PythonParser:
def __init__(self, clinic: Clinic) -> None:
pass

def parse(self, block: Block) -> None:
s = io.StringIO()
with OverrideStdioWith(s):
with contextlib.redirect_stdout(io.StringIO()) as s:
exec(block.input)
block.output = s.getvalue()
block.output = s.getvalue()


class Module:
Expand Down