gh-99242 Catch OSError when calling getloadavg in libregrtest #106705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
Misc/NEWS.d/next/Tests/2023-07-13-02-14-57.gh-issue-99242.DHVhbD.rst
Outdated
Show resolved
Hide resolved
…bD.rst Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
rshah713
approved these changes
Jul 16, 2023
StyXman
reviewed
Jul 19, 2023
| return os.getloadavg()[0] | ||
| try: | ||
| return os.getloadavg()[0] | ||
| except OSError: |
There was a problem hiding this comment.
The raised exception does not have any other information that .args == ('Load averages are unobtainable',), so it's ok if we don't inspect it more to make sure we're catching only the issue at hand.
Member
|
Merged in #121663. Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per suggestions in the comments for #99242 I added a try/except around the call to
os.getloadavg.Perhaps a logged warning here is appropriate as well?