- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 33.3k
 
CI: Make macOS Intel required to succeed #110362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           Be careful: there is known bug on macOS: #110083  | 
    
| 
           In terms of performance, the GHA macOS now seem to have good performance, between Linux and Windows: 
  | 
    
          
 Shall we wait until it's fixed?  | 
    
          
 I didn't check the failure rate. So far, the job was non-voting (didn't block a PR if it failed). I'm tracking too many tests: https://github.com/python/cpython/issues/vstinner :-)  | 
    
| 
           cc @sobolevn  | 
    
| 
           Sorry, @hugovk and @ambv, I could not cleanly backport this to   | 
    
| 
           Sorry, @hugovk and @ambv, I could not cleanly backport this to   | 
    
(cherry picked from commit 5add7a6) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
| 
           GH-130299 is a backport of this pull request to the 3.12 branch.  | 
    
Intel-based macOS aka
build_macosakax86_64-apple-darwinis Tier 1 in PEP 11, which means:mainbranch are not allowed to be merged; any breakage should be fixed or reverted immediately.main, and thus these platforms, working.Let's remove it from the "allowed to fail" list so that it is "required to succeed".
(Windows x86 (32-bit) aka
build_win32akax86_64-pc-windows-msvcis also Tier 1, but I'm not making it required in this PR because some tests are still flaky.)Also remove EOL Python 3.7 from the list of branches. (Or we probably only need bugfix and newer, 3.11+.)