Skip to content

gh-111277: In summarize_stats.py, don't fail fast on invalid ratios #111278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 2 commits into from
Oct 31, 2023
Merged

gh-111277: In summarize_stats.py, don't fail fast on invalid ratios #111278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6c0fa3
gh-111277: In summarize_stats.py, don't fail fast on invalid ratios
mdboom Oct 24, 2023
3626ede
Fix representation of den == None
mdboom Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Tools/scripts/summarize_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,8 +419,6 @@ def __init__(self, num: int, den: int | None, percentage: bool = True):
self.num = num
self.den = den
self.percentage = percentage
if den == 0 and num != 0:
raise ValueError("Invalid denominator")

def __float__(self):
if self.den == 0:
Expand All @@ -431,7 +429,11 @@ def __float__(self):
return self.num / self.den

def markdown(self) -> str:
if self.den == 0 or self.den is None:
if self.den is None:
return ""
elif self.den == 0:
if self.num != 0:
return f"{self.num:,} / 0 !!"
return ""
elif self.percentage:
return f"{self.num / self.den:,.01%}"
Expand Down