gh-115931: Fix SyntaxWarnings in test_unparse
#115935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclips4
reviewed
Feb 26, 2024
|
Thanks @sobolevn for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Member
|
Thanks @sobolevn ! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 26, 2024
) (cherry picked from commit b7383b8) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-115948 is a backport of this pull request to the 3.12 branch. |
pablogsal
pushed a commit
that referenced
this pull request
Feb 26, 2024
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
LukasWoodtli
pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs:
The problem is that the odd amount of
\produces the\escape sequence that is not valid.So, I added two expected warnings + I added two extra cases with valid escape sequences
\n.Thanks a lot to @Eclips4 for the report!
CC @15r10nk
test_unparseraises aSyntaxWarning#115931