bpo-35767: Fix unittest.loader to allow partials as test_functions [3.7] #11600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
reviewed
Jan 18, 2019
Lib/unittest/test/test_loader.py
Outdated
| self.assertEqual(loader.getTestCaseNames(Foo), test_names) | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
yep just removed the extra blank line.
removed an extra newline
|
@ambv: Please replace |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 23, 2019
…ythonGH-11600) (cherry picked from commit fd628cf) Co-authored-by: Jason Fried <me@jasonfried.info>
|
GH-11662 is a backport of this pull request to the 3.7 branch. |
pitrou
reviewed
Jan 23, 2019
| if not callable(testFunc): | ||
| return False | ||
| fullName = '%s.%s' % (testCaseClass.__module__, testFunc.__qualname__) | ||
| fullName = f'%s.%s.%s' % ( |
There was a problem hiding this comment.
The f-string is superfluous here.
There was a problem hiding this comment.
good catch, it didn't wrap well as an f string, forgot to remove the f.
ambv
pushed a commit
that referenced
this pull request
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a regression I first noticed in 3.7 branch.
https://bugs.python.org/issue35767