Skip to content

gh-87115: Set __main__.__spec__ to None in pdb #116141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 29, 2024
Merged

gh-87115: Set __main__.__spec__ to None in pdb #116141

merged 2 commits into from
Feb 29, 2024
+14 −0

Conversation

@gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Feb 29, 2024 •
edited by bedevere-app bot
Loading

__main__.__spec__ should be None when running a script, but pdb does not set it in the namespace. This breaks some code that relies on it (that __spec__ exists in __main__).

@bedevere-app bedevere-app bot mentioned this pull request Feb 29, 2024
Closed
@gaogaotiantian
Copy link
Member Author

gaogaotiantian commented Feb 29, 2024

Hey @iritkatriel could you take a quick look at this? This is a trivial fix - just to set __spec__ to None for script targets. This is a bug fix so it probably should be backported.

@gaogaotiantian gaogaotiantian added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 29, 2024
@iritkatriel iritkatriel enabled auto-merge (squash) February 29, 2024 21:36
@iritkatriel iritkatriel merged commit ccfc042 into python:main Feb 29, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Feb 29, 2024

Thanks @gaogaotiantian for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Feb 29, 2024

Sorry, @gaogaotiantian and @iritkatriel, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ccfc042bbf31e53c44b8aae444afd8365b798422 3.12

@miss-islington-app
Copy link

miss-islington-app bot commented Feb 29, 2024

Sorry, @gaogaotiantian and @iritkatriel, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ccfc042bbf31e53c44b8aae444afd8365b798422 3.11

@gaogaotiantian
Copy link
Member Author

gaogaotiantian commented Feb 29, 2024

I'll work on the cp. I thought the fix is trivial enough so there should not be any conflicts.

@gaogaotiantian gaogaotiantian deleted the fix-pdb-spec branch February 29, 2024 21:41
gaogaotiantian added a commit to gaogaotiantian/cpython that referenced this pull request Feb 29, 2024
@gaogaotiantian
pythongh-87115: Set __main__.__spec__ to None in pdb (python#116141)
8898070 
(cherry picked from commit ccfc042)
gaogaotiantian added a commit to gaogaotiantian/cpython that referenced this pull request Feb 29, 2024
@gaogaotiantian
[3.12] pythongh-87115: Set __main__.__spec__ to None in pdb (pyth…
7e32e59 
…onGH-116141)

(cherry picked from commit ccfc042)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 29, 2024

GH-116154 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 29, 2024
@bedevere-app
Copy link

bedevere-app bot commented Feb 29, 2024

GH-116155 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 29, 2024
gaogaotiantian added a commit to gaogaotiantian/cpython that referenced this pull request Feb 29, 2024
@gaogaotiantian
pythongh-87115: Set __main__.__spec__ to None in pdb (python#116141)
d258bd0 
(cherry picked from commit ccfc042)
gaogaotiantian added a commit to gaogaotiantian/cpython that referenced this pull request Feb 29, 2024
@gaogaotiantian
[3.11] pythongh-87115: Set __main__.__spec__ to None in pdb (pyth…
02c005c 
…onGH-116141)

(cherry picked from commit ccfc042)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
iritkatriel pushed a commit that referenced this pull request Feb 29, 2024
@gaogaotiantian
[3.12] gh-87115: Set __main__.__spec__ to None in pdb (GH-116141) (…
40e9295 
…#116154)

* gh-87115: Set `__main__.__spec__` to `None` in pdb (#116141)

(cherry picked from commit ccfc042)

* [3.12] gh-87115: Set `__main__.__spec__` to `None` in pdb (GH-116141)
(cherry picked from commit ccfc042)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
iritkatriel pushed a commit that referenced this pull request Feb 29, 2024
@gaogaotiantian
[3.11] gh-87115: Set __main__.__spec__ to None in pdb (GH-116141) (…
d3282f5 
…#116155)

* gh-87115: Set `__main__.__spec__` to `None` in pdb (#116141)

(cherry picked from commit ccfc042)

* [3.11] gh-87115: Set `__main__.__spec__` to `None` in pdb (GH-116141)
(cherry picked from commit ccfc042)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@encukou encukou mentioned this pull request Mar 4, 2024
Closed
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@gaogaotiantian @woodruffw
pythongh-87115: Set __main__.__spec__ to None in pdb (python#116141)
f38537f
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@gaogaotiantian @adorilson
pythongh-87115: Set __main__.__spec__ to None in pdb (python#116141)
e04595d
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@gaogaotiantian @diegorusso
pythongh-87115: Set __main__.__spec__ to None in pdb (python#116141)
589e05b
@yihong0618 yihong0618 mentioned this pull request Nov 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

@iritkatriel iritkatriel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaogaotiantian @iritkatriel