Skip to content

Conversation

@aisk
Copy link
Contributor

@aisk aisk commented Mar 20, 2024

@aisk aisk requested a review from vsajip as a code owner March 20, 2024 14:56
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Mar 20, 2024
@aisk aisk requested a review from zooba March 20, 2024 14:56
@aisk aisk added the skip news label Mar 20, 2024
@aisk
Copy link
Contributor Author

aisk commented Mar 20, 2024

The Azure's PPA server seems down now.😢

@zooba
Copy link
Member

zooba commented Mar 20, 2024

Looks like it's launchpad, which hosts the PPA with gdb on it, but yeah definitely down.

At least the Windows tests passed :)

@aisk aisk added 3.11 only security fixes 3.12 only security fixes labels Mar 31, 2024
@aisk
Copy link
Contributor Author

aisk commented Mar 31, 2024

@zooba Hi, can we merge this now? I see there's no more review comments since you approved it. And I see the related PRs for the original issue were backported to 3.10 and 3.11, so It think this should backported too, so I updated the label.

@zooba zooba added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Apr 2, 2024
@zooba zooba merged commit 52f5b7f into python:main Apr 2, 2024
@miss-islington-app
Copy link

Thanks @aisk for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 2, 2024
…GH-117076)

(cherry picked from commit 52f5b7f)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 2, 2024
…GH-117076)

(cherry picked from commit 52f5b7f)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 2, 2024

GH-117461 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 2, 2024
@bedevere-app
Copy link

bedevere-app bot commented Apr 2, 2024

GH-117462 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Apr 2, 2024
@aisk aisk deleted the fix-test-venv2 branch April 2, 2024 13:13
zooba pushed a commit that referenced this pull request Apr 2, 2024
…7076)

gh-115538: Use pathlib to compare prefixes in test_venv (GH-117076)
(cherry picked from commit 52f5b7f)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
zooba pushed a commit that referenced this pull request Apr 2, 2024
…7076)

gh-115538: Use pathlib to compare prefixes in test_venv (GH-117076)
(cherry picked from commit 52f5b7f)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.11 only security fixes 3.12 only security fixes skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants