gh-117224: Move some large uops to external functions #117570
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some uops generate large templates for the JIT, and the hypothesis is that large code makes the JIT run more slowly. This "externalizes"
_INIT_CALL_BOUND_METHOD_EXACT_ARGS,_INIT_CALL_PY_EXACT_ARGS,_COPY_FREE_VARS, and_SET_FUNCTION_ATTRIBUTE. See the original issue #117224 for an explanation of how these specific uops were chosen.The code generator has a new annotation
externalizeto mark uops to be moved to their own function.The code generator now produces two new files:
Python/executor_externals.ccontains the body of the uops as functionsInclude/internal/pycore_executor_externals.hcontains the declarations for those functionsThe generated uop code is then changed to simply call to one of these functions.