gh-120544: Add else: fail() to tests where exception is expected
#120545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
added
skip news
needs backport to 3.12
AlexWaygood
approved these changes
Jun 15, 2024
serhiy-storchaka
approved these changes
Jun 15, 2024
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM.
Normally, we could use assertRaises, but these cases are close to testing unittest itself.
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 15, 2024
…ted (pythonGH-120545) (cherry picked from commit 42ebdd8) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 15, 2024
…ted (pythonGH-120545) (cherry picked from commit 42ebdd8) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-120546 is a backport of this pull request to the 3.13 branch. |
|
GH-120547 is a backport of this pull request to the 3.12 branch. |
AlexWaygood
pushed a commit
that referenced
this pull request
Jun 15, 2024
AlexWaygood
pushed a commit
that referenced
this pull request
Jun 15, 2024
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
else: fail()to test cases where exception is always expected #120544